Build failure with v8 canary #921
Comments
|
The only NAN reference listed appears to be an inclusion of node_object_wrap.h, but that is from nodejs/node. The remaining v8 headers should not be under the paths listed and v8-weak-callback-info.h still exists in v8 master. It appears that something is wrong with however that canary build has been produced, somehow missing headers.
…On October 15, 2021 9:03:24 PM GMT+03:00, Alexey Alexandrov ***@***.***> wrote:
We've been seeing this for a couple of months, filing to see if there are easy fixes.
Building https://github.com/google/pprof-nodejs with v8-canary gives this error:
```
+ timeout 60 npm install --quiet --nodedir=/bin/.nvm/versions/node/v17.0.0-v8-canary20211015aebb1af5c0
node-pre-gyp ERR! install response status 404 Not Found on https://storage.googleapis.com/cloud-profiler/pprof-nodejs/release/v3.2.0/node-v103-linux-x64-glibc.tar.gz
node-pre-gyp WARN Pre-built binaries not installable for ***@***.*** and ***@***.*** (node-v103 ABI, glibc) (falling back to source compile with node-gyp)
node-pre-gyp WARN Hit error response status 404 Not Found on https://storage.googleapis.com/cloud-profiler/pprof-nodejs/release/v3.2.0/node-v103-linux-x64-glibc.tar.gz
In file included from /bin/.nvm/versions/node/v17.0.0-v8-canary20211015aebb1af5c0/include/node/v8-object.h:10,
from /bin/.nvm/versions/node/v17.0.0-v8-canary20211015aebb1af5c0/include/node/v8-array-buffer.h:13,
from /bin/.nvm/versions/node/v17.0.0-v8-canary20211015aebb1af5c0/include/node/v8.h:25,
from /bin/.nvm/versions/node/v17.0.0-v8-canary20211015aebb1af5c0/include/node/node.h:63,
from ../node_modules/nan/nan.h:56,
from ../bindings/profiler.cc:19:
/bin/.nvm/versions/node/v17.0.0-v8-canary20211015aebb1af5c0/include/node/v8-persistent-handle.h:10:10: fatal error: v8-weak-callback-info.h: No such file or directory
10 | #include "v8-weak-callback-info.h" // NOLINT(build/include_directory)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [pprof.target.mk:115: Release/obj.target/pprof/bindings/profiler.o] Error 1
gyp ERR! build error
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#921
|
|
Here is a reproducer: |
|
As far as I can tell, the problem is either that nvm does not install the required V8 headers, or node canaries do not bundle them.
There seems to be some sort of header archive available for canary builds. If it does not contain the missing header, that is the problem, else the problem is nvm not installing them.
https://nodejs.org/download/v8-canary/v17.0.0-v8-canary20211015aebb1af5c0/node-v17.0.0-v8-canary20211015aebb1af5c0-headers.tar.xz
On October 15, 2021 9:51:07 PM GMT+03:00, Alexey Alexandrov ***@***.***> wrote:
Here is a reproducer:
```
***@***.***:~$ cd /tmp
***@***.***:tmp$ mkdir pprof
cd @Azina:tmp$ cd pprof
/tmp/pprof
***@***.***:pprof$ NVM_NODEJS_ORG_MIRROR=https://nodejs.org/download/v8-canary nvm install node
Downloading and installing node v17.0.0-v8-canary20211015aebb1af5c0...
Downloading https://nodejs.org/download/v8-canary/v17.0.0-v8-canary20211015aebb1af5c0/node-v17.0.0-v8-canary20211015aebb1af5c0-linux-x64.tar.xz...
####################################################################################################################################################################################################################################### 100.0%
Computing checksum with sha256sum
Checksums matched!
Now using node v17.0.0-v8-canary20211015aebb1af5c0 (npm v8.0.0)
***@***.***:pprof$ npm install --save pprof
…npm notice
npm notice New minor version of npm available! 8.0.0 -> 8.1.0
npm notice Changelog: https://github.com/npm/cli/releases/tag/v8.1.0
npm notice Run npm install -g ***@***.*** to update!
npm notice
npm ERR! code 1
npm ERR! path /tmp/pprof/node_modules/pprof
npm ERR! command failed
npm ERR! command sh -c node-pre-gyp install --fallback-to-build
npm ERR! make: Entering directory '/tmp/pprof/node_modules/pprof/build'
npm ERR! CXX(target) Release/obj.target/pprof/bindings/profiler.o
npm ERR! make: Leaving directory '/tmp/pprof/node_modules/pprof/build'
npm ERR! Failed to execute '/usr/local/google/home/aalexand/.nvm/versions/node/v17.0.0-v8-canary20211015aebb1af5c0/bin/node /usr/local/google/home/aalexand/.nvm/versions/node/v17.0.0-v8-canary20211015aebb1af5c0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/tmp/pprof/node_modules/pprof/build/node-v103-linux-x64-glibc/pprof.node --module_name=pprof --module_path=/tmp/pprof/node_modules/pprof/build/node-v103-linux-x64-glibc --napi_version=8 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v103' (1)
npm ERR! node-pre-gyp info it worked if it ends with ok
npm ERR! node-pre-gyp info using ***@***.***
npm ERR! node-pre-gyp info using ***@***.*** | linux | x64
npm ERR! node-pre-gyp info check checked for "/tmp/pprof/node_modules/pprof/build/node-v103-linux-x64-glibc/pprof.node" (not found)
npm ERR! node-pre-gyp http GET https://storage.googleapis.com/cloud-profiler/pprof-nodejs/release/v3.2.0/node-v103-linux-x64-glibc.tar.gz
npm ERR! node-pre-gyp ERR! install response status 404 Not Found on https://storage.googleapis.com/cloud-profiler/pprof-nodejs/release/v3.2.0/node-v103-linux-x64-glibc.tar.gz
npm ERR! node-pre-gyp WARN Pre-built binaries not installable for ***@***.*** and ***@***.*** (node-v103 ABI, glibc) (falling back to source compile with node-gyp)
npm ERR! node-pre-gyp WARN Hit error response status 404 Not Found on https://storage.googleapis.com/cloud-profiler/pprof-nodejs/release/v3.2.0/node-v103-linux-x64-glibc.tar.gz
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using ***@***.***
npm ERR! gyp info using ***@***.*** | linux | x64
npm ERR! gyp info ok
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using ***@***.***
npm ERR! gyp info using ***@***.*** | linux | x64
npm ERR! gyp info find Python using Python version 3.9.7 found at "/usr/bin/python3"
npm ERR! gyp http GET https://nodejs.org/download/v8-canary/v17.0.0-v8-canary20211015aebb1af5c0/node-v17.0.0-v8-canary20211015aebb1af5c0-headers.tar.gz
npm ERR! gyp http 200 https://nodejs.org/download/v8-canary/v17.0.0-v8-canary20211015aebb1af5c0/node-v17.0.0-v8-canary20211015aebb1af5c0-headers.tar.gz
npm ERR! gyp http GET https://nodejs.org/download/v8-canary/v17.0.0-v8-canary20211015aebb1af5c0/SHASUMS256.txt
npm ERR! gyp http 200 https://nodejs.org/download/v8-canary/v17.0.0-v8-canary20211015aebb1af5c0/SHASUMS256.txt
npm ERR! gyp info spawn /usr/bin/python3
npm ERR! gyp info spawn args [
npm ERR! gyp info spawn args '/usr/local/google/home/aalexand/.nvm/versions/node/v17.0.0-v8-canary20211015aebb1af5c0/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
npm ERR! gyp info spawn args 'binding.gyp',
npm ERR! gyp info spawn args '-f',
npm ERR! gyp info spawn args 'make',
npm ERR! gyp info spawn args '-I',
npm ERR! gyp info spawn args '/tmp/pprof/node_modules/pprof/build/config.gypi',
npm ERR! gyp info spawn args '-I',
npm ERR! gyp info spawn args '/usr/local/google/home/aalexand/.nvm/versions/node/v17.0.0-v8-canary20211015aebb1af5c0/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
npm ERR! gyp info spawn args '-I',
npm ERR! gyp info spawn args '/usr/local/google/home/aalexand/.cache/node-gyp/17.0.0-v8-canary20211015aebb1af5c0/include/node/common.gypi',
npm ERR! gyp info spawn args '-Dlibrary=shared_library',
npm ERR! gyp info spawn args '-Dvisibility=default',
npm ERR! gyp info spawn args '-Dnode_root_dir=/usr/local/google/home/aalexand/.cache/node-gyp/17.0.0-v8-canary20211015aebb1af5c0',
npm ERR! gyp info spawn args '-Dnode_gyp_dir=/usr/local/google/home/aalexand/.nvm/versions/node/v17.0.0-v8-canary20211015aebb1af5c0/lib/node_modules/npm/node_modules/node-gyp',
npm ERR! gyp info spawn args '-Dnode_lib_file=/usr/local/google/home/aalexand/.cache/node-gyp/17.0.0-v8-canary20211015aebb1af5c0/<(target_arch)/node.lib',
npm ERR! gyp info spawn args '-Dmodule_root_dir=/tmp/pprof/node_modules/pprof',
npm ERR! gyp info spawn args '-Dnode_engine=v8',
npm ERR! gyp info spawn args '--depth=.',
npm ERR! gyp info spawn args '--no-parallel',
npm ERR! gyp info spawn args '--generator-output',
npm ERR! gyp info spawn args 'build',
npm ERR! gyp info spawn args '-Goutput_dir=.'
npm ERR! gyp info spawn args ]
npm ERR! gyp info ok
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using ***@***.***
npm ERR! gyp info using ***@***.*** | linux | x64
npm ERR! gyp info spawn make
npm ERR! gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
npm ERR! In file included from /usr/local/google/home/aalexand/.cache/node-gyp/17.0.0-v8-canary20211015aebb1af5c0/include/node/v8-object.h:10,
npm ERR! from /usr/local/google/home/aalexand/.cache/node-gyp/17.0.0-v8-canary20211015aebb1af5c0/include/node/v8-array-buffer.h:13,
npm ERR! from /usr/local/google/home/aalexand/.cache/node-gyp/17.0.0-v8-canary20211015aebb1af5c0/include/node/v8.h:25,
npm ERR! from /usr/local/google/home/aalexand/.cache/node-gyp/17.0.0-v8-canary20211015aebb1af5c0/include/node/node.h:63,
npm ERR! from ../../nan/nan.h:58,
npm ERR! from ../bindings/profiler.cc:19:
npm ERR! /usr/local/google/home/aalexand/.cache/node-gyp/17.0.0-v8-canary20211015aebb1af5c0/include/node/v8-persistent-handle.h:10:10: fatal error: v8-weak-callback-info.h: No such file or directory
npm ERR! 10 | #include "v8-weak-callback-info.h" // NOLINT(build/include_directory)
npm ERR! | ^~~~~~~~~~~~~~~~~~~~~~~~~
npm ERR! compilation terminated.
npm ERR! make: *** [pprof.target.mk:115: Release/obj.target/pprof/bindings/profiler.o] Error 1
npm ERR! gyp ERR! build error
npm ERR! gyp ERR! stack Error: `make` failed with exit code: 2
npm ERR! gyp ERR! stack at ChildProcess.onExit (/usr/local/google/home/aalexand/.nvm/versions/node/v17.0.0-v8-canary20211015aebb1af5c0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
npm ERR! gyp ERR! stack at ChildProcess.emit (node:events:390:28)
npm ERR! gyp ERR! stack at Process.ChildProcess._handle.onexit (node:internal/child_process:290:12)
npm ERR! gyp ERR! System Linux 5.10.46-4rodete4-amd64
npm ERR! gyp ERR! command "/usr/local/google/home/aalexand/.nvm/versions/node/v17.0.0-v8-canary20211015aebb1af5c0/bin/node" "/usr/local/google/home/aalexand/.nvm/versions/node/v17.0.0-v8-canary20211015aebb1af5c0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--module=/tmp/pprof/node_modules/pprof/build/node-v103-linux-x64-glibc/pprof.node" "--module_name=pprof" "--module_path=/tmp/pprof/node_modules/pprof/build/node-v103-linux-x64-glibc" "--napi_version=8" "--node_abi_napi=napi" "--napi_build_version=0" "--node_napi_label=node-v103"
npm ERR! gyp ERR! cwd /tmp/pprof/node_modules/pprof
npm ERR! gyp ERR! node -v v17.0.0-v8-canary20211015aebb1af5c0
npm ERR! gyp ERR! node-gyp -v v8.2.0
npm ERR! gyp ERR! not ok
npm ERR! node-pre-gyp ERR! build error
npm ERR! node-pre-gyp ERR! stack Error: Failed to execute '/usr/local/google/home/aalexand/.nvm/versions/node/v17.0.0-v8-canary20211015aebb1af5c0/bin/node /usr/local/google/home/aalexand/.nvm/versions/node/v17.0.0-v8-canary20211015aebb1af5c0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/tmp/pprof/node_modules/pprof/build/node-v103-linux-x64-glibc/pprof.node --module_name=pprof --module_path=/tmp/pprof/node_modules/pprof/build/node-v103-linux-x64-glibc --napi_version=8 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v103' (1)
npm ERR! node-pre-gyp ERR! stack at ChildProcess.<anonymous> ***@***.***/node-pre-gyp/lib/util/compile.js:89:23)
npm ERR! node-pre-gyp ERR! stack at ChildProcess.emit (node:events:390:28)
npm ERR! node-pre-gyp ERR! stack at maybeClose (node:internal/child_process:1062:16)
npm ERR! node-pre-gyp ERR! stack at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)
npm ERR! node-pre-gyp ERR! System Linux 5.10.46-4rodete4-amd64
npm ERR! node-pre-gyp ERR! command "/usr/local/google/home/aalexand/.nvm/versions/node/v17.0.0-v8-canary20211015aebb1af5c0/bin/node" "/tmp/pprof/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
npm ERR! node-pre-gyp ERR! cwd /tmp/pprof/node_modules/pprof
npm ERR! node-pre-gyp ERR! node -v v17.0.0-v8-canary20211015aebb1af5c0
npm ERR! node-pre-gyp ERR! node-pre-gyp -v v1.0.5
npm ERR! node-pre-gyp ERR! not ok
npm ERR! A complete log of this run can be found in:
npm ERR! /usr/local/google/home/aalexand/.npm/_logs/2021-10-15T18_50_25_956Z-debug.log
```
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#921 (comment)
|
|
I think nodejs/node/pull/40526 will fix this |
|
@ewanharris thanks! |
|
Ah my bad, I see v8-weak-callback-info.h is still missing. Commenting on the PR |
|
Looks like it's fixed - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We've been seeing this for a couple of months, filing to see if there are easy fixes.
Building https://github.com/google/pprof-nodejs with v8-canary gives this error:
The text was updated successfully, but these errors were encountered: