Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular hang in thread safe function in CI testing #1150

Closed
mhdawson opened this issue Mar 17, 2022 · 5 comments
Closed

Regular hang in thread safe function in CI testing #1150

mhdawson opened this issue Mar 17, 2022 · 5 comments

Comments

@mhdawson
Copy link
Member

mhdawson commented Mar 17, 2022

Seems consistent on Debian 8 and Node.js 12 but I've seen it intermittently on other platforms as well

https://ci.nodejs.org/job/node-test-node-addon-api-new/nodes=debian8-64/5608

@mhdawson
Copy link
Member Author

Running test 'threadsafe_function/threadsafe_function_unref'
Running test 'typed_threadsafe_function/typed_threadsafe_function'
Running test 'typed_threadsafe_function/typed_threadsafe_function_ctx'
Running test 'typed_threadsafe_function/typed_threadsafe_function_existing_tsfn'
Running test 'typed_threadsafe_function/typed_threadsafe_function_ptr'
Running test 'typed_threadsafe_function/typed_threadsafe_function_sum'
Build timed out (after 60 minutes). Marking the build as failed.
Tests aborted with SIGTERM
npm ERR! Test failed.  See above for more details.

@mhdawson mhdawson changed the title Regular hand in thread safe function in CI testing Regular hang in thread safe function in CI testing Mar 17, 2022
@KevinEady
Copy link
Contributor

We discussed this in the 18 March Node API meeting.

How long have the tests been failing on Debian, since you said it seems consistent on that OS?

These tests are a port of the existing TSFN tests into the TypedTSFN so it would be a little odd for there to be an issue in the test unless it was also failing on TSFN. Maybe writing the tests in the underlying C-level Node API to see if there is any issue in the test or the core itself.

@mhdawson
Copy link
Member Author

This time in s390 - https://ci.nodejs.org/job/node-test-node-addon-api-new/nodes=rhel8-s390x/5615/console

In past runs it seemed to fail every time on debian but not last night :).

There is also an issue on the core side which is likely related - nodejs/reliability#224 (4 failures shown in that reliabiliity report)

@KevinEady
Copy link
Contributor

Hi @mhdawson ,

I installed a debian 8 VM and again I am unable to reproduce any failures locally after 100 full test runs (not just threadsafe tests). I think we need to go with the next approach, getting access to the build server?

Thanks, Kevin

@mhdawson
Copy link
Member Author

mhdawson commented Apr 8, 2022

Created nodejs/build#2919 to request access. Hopefully early next week we can get you access to the machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants