[WIP] enable unit-tests #1030

deepakrkris · 2021-07-30T06:50:10Z

No description provided.

KevinEady

Don't want to lose track of some discussion we had from our previous meetings:

Standardizing the test + object names so you wouldn't need the testFunctionsMap
Merging your filtering capabilities with the existing 'npm test' command. The CI would run it with no filters, and users locally can optionally provide the filters to run at testing time.

deepakrkris · 2021-08-27T05:36:37Z

Don't want to lose track of some discussion we had from our previous meetings:

Standardizing the test + object names so you wouldn't need the testFunctionsMap

Merging your filtering capabilities with the existing 'npm test' command. The CI would run it with no filters, and users locally can optionally provide the filters to run at testing time.

@KevinEady thanks for summarizing , I have opened PR
#1055 and
#1056
for the first requirement

Not sure how this ever made its way into the API, but people should *never* use this.

PR-URL: nodejs#937 Reviewed-By: Michael Dawson <midawson@redhat.com>

* doc: fix tab indent

…odejs#929) * Fixes issue 258.

Added windows-2016 as virtual environment. PR-URL: nodejs#948 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

Also fixed lint errors. Fixes: nodejs#952 PR-URL: nodejs#953 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

Done by running: sed -i "s/N-API/Node-API/g" doc/* sed -i "s/N-API/Node-API/g" README.md CONTRIBUTING.md Fixes: nodejs#950 PR-URL: nodejs#951 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

Currently, deprecation notices are always right between two function signatures and it's virtually impossible to be certain whether they refer to the previous signature or the next signature. PR-URL: nodejs#942 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#939 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#955 Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#974 Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#973 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#976 Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#1005 Reviewed-By: Michael Dawson <midawson@redhat.com>

Fixes: nodejs#1007 PR-URL: nodejs#1009 Reviewed-By: Michael Dawson <midawson@redhat.com>

When terminating an environment (e.g., by calling worker.terminate), napi_throw, which is called by Error::ThrowAsJavaScriptException, returns napi_pending_exception, which is then incorrectly treated as a fatal error resulting in a crash. PR-URL: nodejs#975 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#1004 Reviewed-By: Michael Dawson <midawson@redhat.com>

Fixes: nodejs#1011 PR-URL: nodejs#1013 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: nodejs#1015 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com>

PR-URL: nodejs#972 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>

Throw an exception when receiving a null pointer for the `char *` and `char16_t *` overloads of `String::New` that looks identical to an error that core would have thrown under the circumstances (`napi_invalid_arg`). Also, rename the test methods to conform with our naming convention. PR-URL: nodejs#1019 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

fixes: nodejs#1022 The objectwrap_worker_thread and symbol tests were not waiting for the test to complete before the subsequent tests were started. This caused intermitted crashes in the CI. Updated both tests so that they complete before the next test runs. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#1024 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Add CleanupHook support to Env PR-URL: nodejs#1014 Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#927 Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#1061 Reviewed-By: Michael Dawson <midawson@redhat.com>

* doc: fixed doc about how to enable C++ exceptions. PR-URL: nodejs#1059 Reviewed-By: Michael Dawson <midawson@redhat.com>

- fix error reported about possible use of un-initialized variable from newer compiler Signed-off-by: Michael Dawson <mdawson@devrus.com>

- change all unit test file names to snake case this helps in parsing file names to tokens and infer metadata like export initializers - all other changes other than file names is due to linter errors PR-URL: nodejs#1056 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>

PR-URL: nodejs#1055 Reviewed-By: Michael Dawson <midawson@redhat.com>

I guess if these were broken in practice, V8/Node.js itself would also experience difficulties with it, but there’s no real reason not to use the proper alternatives. PR-URL: nodejs#1070 Reviewed-By: Michael Dawson <midawson@redhat.com>

Function::New fails to compile when given a move-only functor. For example, when constructing a callback function for Promise#then, a lambda might capture an ObjectReference. Creating a Function for such a lambda results in a compilation error. Tweak Function::New to work with move-only functors. For existing users of Function::New, this commit should not change behavior.

* lint: add eslint based on config-semistandard

deepakrkris · 2021-09-23T18:11:55Z

@KevinEady @mhdawson I have opened a new PR #1078 and closed this branch , had troubles with rebasing

deepakrkris force-pushed the unit-tests branch from 8e3abad to 56dd4af Compare July 30, 2021 06:51

deepakrkris changed the title ~~enable unit-tests~~ [WIP] enable unit-tests Jul 30, 2021

KevinEady reviewed Aug 20, 2021

View reviewed changes

deepakrkris force-pushed the unit-tests branch from 528dcde to e74bb96 Compare September 11, 2021 23:29

deepakrkris force-pushed the unit-tests branch 3 times, most recently from 3b9928f to 5f3f131 Compare September 23, 2021 17:53

addaleax and others added 22 commits September 23, 2021 10:59

doc: warn about SuppressDestruct()

8de895c

Not sure how this ever made its way into the API, but people should *never* use this.

fixup

97a0eb3

fixup

1647b21

test: dd tests for Function constructors

09f39de

PR-URL: nodejs#937 Reviewed-By: Michael Dawson <midawson@redhat.com>

chore: fixup linter commands (nodejs#940)

cf1c43b

Fix tab indent (nodejs#938)

e320666

* doc: fix tab indent

doc: sync Object::Set value arg with Value::From (nodejs#933)

666e9ff

doc: added some warnings for buffer and array buffer factory method. (n…

81d41ee

…odejs#929) * Fixes issue 258.

build: add CI configuration for Windows

d198de0

Added windows-2016 as virtual environment. PR-URL: nodejs#948 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

src: rename N-API with Node-API on comments

5110815

Also fixed lint errors. Fixes: nodejs#952 PR-URL: nodejs#953 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

Finished tests relating to fetch property from Global Object

0b7e872

PR-URL: nodejs#939 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

src: added Freeze and Seal method to Object class.

bdf0eef

PR-URL: nodejs#955 Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

Update CONTRIBUTING.md (nodejs#966)

79e0786

src: add pull request template (nodejs#967)

837a820

Added badges for Node-API v7 and v8. (nodejs#954)

ac71abb

doc: correct struct definition (nodejs#969)

a5280a8

fix: key for wapping drawing's system condition (nodejs#970)

34502c3

test: fix intermittent TSFN crashes

b74908f

PR-URL: nodejs#974 Reviewed-By: Michael Dawson <midawson@redhat.com>

test: rename misspelled parameters

3aad6da

PR-URL: nodejs#973 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

test: run test suites with helpers

ad4cc6f

PR-URL: nodejs#976 Reviewed-By: Michael Dawson <midawson@redhat.com>

NickNaso and others added 26 commits September 23, 2021 10:59

Update version on package.json.

c2ec24b

test: function reference call & construct

83e18ae

PR-URL: nodejs#1005 Reviewed-By: Michael Dawson <midawson@redhat.com>

src: fix gcc-11 c++20 compilation

c1734a9

Fixes: nodejs#1007 PR-URL: nodejs#1009 Reviewed-By: Michael Dawson <midawson@redhat.com>

Prepare release 4.0.0.

5d4d358

src: set default return value of Reference Ref/Unref to 0

cc11d72

PR-URL: nodejs#1004 Reviewed-By: Michael Dawson <midawson@redhat.com>

doc: update examples for context sensitivity

92d1af5

Fixes: nodejs#1011 PR-URL: nodejs#1013 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

test: dd check for nullptr inside String init

4f9b270

PR-URL: nodejs#1015 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com>

test: add first set of symbol tests

e937efb

PR-URL: nodejs#972 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>

src: add AddCleanupHook

daf910e

Add CleanupHook support to Env PR-URL: nodejs#1014 Reviewed-By: Michael Dawson <midawson@redhat.com>

src: return Maybe on pending exception when cpp exception disabled

6f79043

PR-URL: nodejs#927 Reviewed-By: Michael Dawson <midawson@redhat.com>

Prepare release 4.1.0.

ecd9eef

test: fixed the way to enable C++ exceptions. (nodejs#1061)

e9cd96a

PR-URL: nodejs#1061 Reviewed-By: Michael Dawson <midawson@redhat.com>

doc: fix documentation about how to enable C++ exception (nodejs#1059)

7b573b1

* doc: fixed doc about how to enable C++ exceptions. PR-URL: nodejs#1059 Reviewed-By: Michael Dawson <midawson@redhat.com>

test: fix errors reported by newer compiler

309ff88

- fix error reported about possible use of un-initialized variable from newer compiler Signed-off-by: Michael Dawson <mdawson@devrus.com>

test: run tests with opts to prefix bld root path

1708851

PR-URL: nodejs#1055 Reviewed-By: Michael Dawson <midawson@redhat.com>

docs: fix typo and formatting (nodejs#1062)

55edda6

docs: fix typos (nodejs#1068)

0aa256e

src: fix casts to not be undefined behavior

c82782f

I guess if these were broken in practice, V8/Node.js itself would also experience difficulties with it, but there’s no real reason not to use the proper alternatives. PR-URL: nodejs#1070 Reviewed-By: Michael Dawson <midawson@redhat.com>

Prepare release v4.2.0.

3de1e38

lint: add eslint based on config-semistandard (nodejs#1067)

764dc00

* lint: add eslint based on config-semistandard

enable unit tests

23f5625

deepakrkris force-pushed the unit-tests branch from 5f3f131 to 23f5625 Compare September 23, 2021 18:05

deepakrkris closed this Sep 23, 2021

deepakrkris deleted the unit-tests branch September 23, 2021 18:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] enable unit-tests #1030

[WIP] enable unit-tests #1030

deepakrkris commented Jul 30, 2021

KevinEady left a comment

deepakrkris commented Aug 27, 2021 •

edited

Loading

deepakrkris commented Sep 23, 2021

[WIP] enable unit-tests #1030

[WIP] enable unit-tests #1030

Conversation

deepakrkris commented Jul 30, 2021

KevinEady left a comment

Choose a reason for hiding this comment

deepakrkris commented Aug 27, 2021 • edited Loading

deepakrkris commented Sep 23, 2021

deepakrkris commented Aug 27, 2021 •

edited

Loading