Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add tests for missing Env methods #1254

Closed
wants to merge 1 commit into from

Conversation

JckXia
Copy link
Member

@JckXia JckXia commented Dec 20, 2022

This PR aims to close #1050 (comment)

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Jan 3, 2023
PR-URL: #1254
Reviewed-By: Michael Dawson <midawson@redhat.com
@mhdawson
Copy link
Member

mhdawson commented Jan 3, 2023

Landed as ad76256

@mhdawson mhdawson closed this Jan 3, 2023
@JckXia JckXia deleted the add-test-for-missing-env-func branch January 3, 2023 23:16
austinli64 added a commit to austinli64/node-addon-api that referenced this pull request May 9, 2023
PR-URL: nodejs/node-addon-api#1254
Reviewed-By: Michael Dawson <midawson@redhat.com
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
PR-URL: nodejs/node-addon-api#1254
Reviewed-By: Michael Dawson <midawson@redhat.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test] Unit test coverage for Env class
2 participants