[Test] Add tests for async progress queue worker #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinEady
requested changes
May 12, 2023
test/async_progress_queue_worker.js
Outdated
| } | ||
|
|
||
| async function asyncProgressWorkerNoCbOverloads (bindingFunction) { | ||
| bindingFunction(common.mustCall(() => {})); |
There was a problem hiding this comment.
No need for noop arg for mustCall.
test/async_progress_queue_worker.js
Outdated
Comment on lines
52
to
53
| }).catch(common.mustNotCall()); | ||
| resolve(); |
There was a problem hiding this comment.
The common.mustNotCall() should be the Promise's reject callback, and the resolve() belongs inside the hooks.then() callback after the assertion.
This will provide the actual assertion error (in case of failure). Try changing the assertion object, eg. the destroy event name to __destroy.
With your code, you'll get:
> AssertionError [ERR_ASSERTION]: function should not have been called
at mustNotCall (/Users/kevineady/Documents/Projects/node-addon-api/test/common/index.js:120:12) {
generatedMessage: false,
code: 'ERR_ASSERTION',
actual: undefined,
expected: undefined,
operator: 'fail'
}
With the suggested changes, you'll get:
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected ... Lines skipped
[
{
...
},
{
+ eventName: 'destroy'
- eventName: '__destroy'
}
]
at /Users/kevineady/Documents/Projects/node-addon-api/test/async_progress_queue_worker.js:41:14 {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: [Array],
expected: [Array],
operator: 'deepStrictEqual'
}
There was a problem hiding this comment.
Sorry for the wait. Thank you for pointing this out! I borrowed this pattern from other places in the test suites. Will draft up another PR to make these fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1043.
Similar to PR #1307 but for AsyncProgressQueueWorker