Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8.0.0 Release Proposal #1459

Merged
merged 1 commit into from
Mar 5, 2024
Merged

v8.0.0 Release Proposal #1459

merged 1 commit into from
Mar 5, 2024

Conversation

legendecas
Copy link
Member

Closes #1381

@NickNaso
Copy link
Member

NickNaso commented Mar 1, 2024

CI:

Version Job Status
main https://ci.nodejs.org/job/node-test-node-addon-api-new/8527/ ✓
v21.x https://ci.nodejs.org/job/node-test-node-addon-api-new/8528/ ✓
v20.x https://ci.nodejs.org/job/node-test-node-addon-api-new/8529/ ✓
v18.x https://ci.nodejs.org/job/node-test-node-addon-api-new/8530 ✓

mhdawson
mhdawson approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas legendecas merged commit d1ba547 into nodejs:main Mar 5, 2024
26 checks passed
@legendecas legendecas deleted the v8.0.0-proposal branch March 5, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickNaso NickNaso NickNaso approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New SemVer Major release?
3 participants
@legendecas @NickNaso @mhdawson