Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests work on all Node versions #44

Merged
merged 2 commits into from
May 23, 2017
Merged

Make tests work on all Node versions #44

merged 2 commits into from
May 23, 2017
+201 −96

Commits on May 23, 2017

  1. Make tests work on all Node versions 

     - Make GC tests (arraybuffer, buffer, external) async, to account for
   different GC behavior with different versions of V8 and ChakraCore,
   similar to nodejs/node#13121
 - In test/index.js, use the --napi-modules and --expose-gc
   command-line flags automatically.
 - Add missing entry for object tests in index.js.
 - Remove check for writable attribute on accessor property
   descriptors; it should not be there according to the JS spec.
 - Remove the explicit dependency on node-gyp in package.json.
   (NPM carries its own copy of node-gyp.)
    @jasongin
    jasongin committed May 23, 2017
    Configuration menu
    Copy the full SHA
    76f85b6 View commit details
    Browse the repository at this point in the history

  2. Fix error rethrow tests 

    Improper rethrow of an Error caught by reference caused a double napi_ref delete, which failed in release builds of Node-ChakraCore.
    @jasongin
    jasongin committed May 23, 2017
    Configuration menu
    Copy the full SHA
    d772f05 View commit details
    Browse the repository at this point in the history