Set up CI services #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks nice |
jasongin
reviewed
May 21, 2017
| - rm -rf ~/.nvm | ||
| - git clone --branch v0.33.2 https://github.com/creationix/nvm.git ~/.nvm | ||
| - source ~/.nvm/nvm.sh | ||
| - nvm install "$TRAVIS_NODE_VERSION" |
There was a problem hiding this comment.
I'd suggest using nvs instead so that Node-ChakraCore can be included in the matrix. Also maybe the latest Node-V8 nightly build. See https://github.com/jasongin/nvs/blob/master/doc/CI.md
Or I can make that change later.
jasongin
reviewed
May 21, 2017
| - export CFLAGS="$CFLAGS -O3 --coverage" LDFLAGS="$LDFLAGS --coverage" | ||
| - echo "CFLAGS=\"$CFLAGS\" LDFLAGS=\"$LDFLAGS\"" | ||
| install: | ||
| - npm install $NPMOPT |
There was a problem hiding this comment.
The npm install is not really needed, since after #44 there are no package dependencies. But I guess we could keep it in case any dependencies are added in the future?
|
@boingoing You recently encountered that problem with |
|
I fixed the |
jasongin
approved these changes
May 23, 2017
|
I'm going to go ahead and merge this, so I can do some more work on top of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run for this PR:
Notably, builds are currently failing on Node 4 or 6 on macOS with:
Everything else is green, though.
(Coverage doesn’t seem to be working quite yet but that might just be because tests are failing.)