Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable caching in ArrayBuffer #611

Closed
wants to merge 2 commits into from
Closed

Disable caching in ArrayBuffer #611

wants to merge 2 commits into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Nov 28, 2019 •
edited
Loading

Caching the data pointer and the byteLength in the ArrayBuffer class causes it to behave incorrectly when the buffer is detached, as demonstrated by the test case. The current behavior is dangerous since it depends on whether the Napi::Value was cast to an Napi::ArrayBuffer before or after being detached.

@tniessen tniessen force-pushed the disable-caching-in-arraybuffer branch from fbf3354 to 6f1cd3e Compare November 28, 2019 14:02
@tniessen
Disable caching in ArrayBuffer
25686d8 
Caching the data pointer and the byteLength in the ArrayBuffer class
causes it to behave incorrectly when the buffer is detached.
@tniessen tniessen force-pushed the disable-caching-in-arraybuffer branch from 6f1cd3e to 25686d8 Compare November 28, 2019 14:53
NickNaso
NickNaso reviewed Nov 28, 2019
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tniessen good catch. Could I ask you to add a forward declaration for ArrayBuffer in napi.h and place it after Array?
Thanks for this contribution.

mhdawson
mhdawson approved these changes Nov 28, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM seems reasonable to me.

NickNaso
NickNaso approved these changes Nov 29, 2019
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tniessen Thanks

@tniessen
Copy link
Member Author

@NickNaso Done. May I ask why that is necessary?

@tniessen tniessen added the bug label Dec 1, 2019
@gabrielschulhof
Copy link
Contributor

gabrielschulhof commented Dec 14, 2019 •
edited
Loading

CI:

Version Job Status
v14.x https://ci.nodejs.org/job/node-test-node-addon-api-new/1382/ ✓
v12.x https://ci.nodejs.org/job/node-test-node-addon-api-new/1383/ ✓
v10.x https://ci.nodejs.org/job/node-test-node-addon-api-new/1384/ ✓
v8.x https://ci.nodejs.org/job/node-test-node-addon-api-new/1385/ ✓

gabrielschulhof pushed a commit that referenced this pull request Dec 14, 2019
@tniessen
Disable caching in ArrayBuffer
b72f1d6 
Caching the data pointer and the byteLength in the ArrayBuffer class
causes it to behave incorrectly when the buffer is detached.

PR-URL: #611
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gabrielschulhof
Copy link
Contributor

Landed in b72f1d6.

@tniessen tniessen deleted the disable-caching-in-arraybuffer branch January 23, 2020 03:47
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
Disable caching in ArrayBuffer
409a0f9 
Caching the data pointer and the byteLength in the ArrayBuffer class
causes it to behave incorrectly when the buffer is detached.

PR-URL: nodejs/node-addon-api#611
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
Disable caching in ArrayBuffer
2cb0b63 
Caching the data pointer and the byteLength in the ArrayBuffer class
causes it to behave incorrectly when the buffer is detached.

PR-URL: nodejs/node-addon-api#611
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
Disable caching in ArrayBuffer
28b32bc 
Caching the data pointer and the byteLength in the ArrayBuffer class
causes it to behave incorrectly when the buffer is detached.

PR-URL: nodejs/node-addon-api#611
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
austinli64 added a commit to austinli64/node-addon-api that referenced this pull request May 9, 2023
@austinli64
Disable caching in ArrayBuffer
e38ad4e 
Caching the data pointer and the byteLength in the ArrayBuffer class
causes it to behave incorrectly when the buffer is detached.

PR-URL: nodejs/node-addon-api#611
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
Disable caching in ArrayBuffer
3a6bcec 
Caching the data pointer and the byteLength in the ArrayBuffer class
causes it to behave incorrectly when the buffer is detached.

PR-URL: nodejs/node-addon-api#611
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickNaso NickNaso NickNaso approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tniessen @gabrielschulhof @NickNaso @mhdawson