Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix std::string encoding #619

Merged
merged 1 commit into from Dec 5, 2019
Merged

Conversation

@tniessen
Copy link
Member

tniessen commented Dec 2, 2019

  1. "ANSI" is misleading and not a good description of any string encoding. It is commonly used to refer to "Windows code pages" such as Windows-125x, but these code pages have never been standardized by ANSI.
  2. It is wrong, we treat std::string as UTF8.
1. "ANSI" is misleading and not a good description of any string
   encoding. It is commonly used to refer to "Windows code pages"
   such as Windows-125x, but these code pages have never been
   standardized by ANSI.
2. It is wrong, we treat std::string as UTF8.
@tniessen tniessen added the doc label Dec 2, 2019
Copy link
Member

NickNaso left a comment

LGTM

Copy link
Contributor

KevinEady left a comment

LGTM

Copy link
Member

mhdawson left a comment

LGTM

@mhdawson mhdawson merged commit 3acc4b3 into nodejs:master Dec 5, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.