New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error: do not replace pending exception #629

Closed

gabrielschulhof wants to merge 1 commit into nodejs:master from gabrielschulhof:do-not-replace-exception

Commits on Dec 13, 2019

error: do not replace pending exception

Only construct a `Napi::Error` from the last non-`napi_ok` error code
if there is no exception pending.

A consequence for the object property test suite is that it must now
expect the exception thrown by the engine when N-API core attempts
to convert the undefined value to an object.

Fixes: nodejs#621

Gabriel Schulhof committed Dec 13, 2019