Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support bigint64/biguint64 in TypedArray::ElementSize() #705

Closed
wants to merge 3 commits into from
Closed

support bigint64/biguint64 in TypedArray::ElementSize() #705

wants to merge 3 commits into from

Conversation

fs-eire
Copy link
Contributor

@fs-eire fs-eire commented Apr 18, 2020

No description provided.

legendecas
legendecas approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

napi-inl.h Outdated
@@ -1628,6 +1628,10 @@ inline uint8_t TypedArray::ElementSize() const {
case napi_float32_array:
return 4;
case napi_float64_array:
#ifdef NAPI_EXPERIMENTAL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N-API BigInt support has been out of experimental and can be guarded with

#if (NAPI_VERSION >= 6)

Check out #697 for more contexts.

@mhdawson mhdawson mentioned this pull request Apr 20, 2020
Closed
8 tasks
mhdawson
mhdawson reviewed Apr 20, 2020
View reviewed changes
napi-inl.h Outdated
@@ -1628,6 +1628,10 @@ inline uint8_t TypedArray::ElementSize() const {
case napi_float32_array:
return 4;
case napi_float64_array:
#ifdef NAPI_EXPERIMENTAL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#ifdef NAPI_EXPERIMENTAL
#if (NAPI_VERSION > 5)

mhdawson
mhdawson reviewed Apr 20, 2020
View reviewed changes
napi-inl.h Outdated
#ifdef NAPI_EXPERIMENTAL
case napi_bigint64_array:
case napi_biguint64_array:
#endif // NAPI_EXPERIMENTAL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#endif // NAPI_EXPERIMENTAL
#endif // NAPI_VERSION > 5

NickNaso
NickNaso reviewed Apr 20, 2020
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the changes proposed by @mhdawson will be addressed.

NickNaso
NickNaso approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @fs-eire Thanks for your contribution.

gabrielschulhof
gabrielschulhof approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@gabrielschulhof gabrielschulhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit

napi-inl.h Outdated Show resolved Hide resolved
@mhdawson @gabrielschulhof
Update napi-inl.h
3b266f2 
Co-Authored-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
mhdawson
mhdawson approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Apr 24, 2020
@fs-eire @mhdawson
doc: fix support bigint64/biguint64 guards
4de23c9 
PR-URL: #705
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
@mhdawson
Copy link
Member

Landed as 4de23c9

@mhdawson mhdawson closed this Apr 24, 2020
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
doc: fix support bigint64/biguint64 guards
d35d0a9 
PR-URL: nodejs/node-addon-api#705
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
doc: fix support bigint64/biguint64 guards
03d9d23 
PR-URL: nodejs/node-addon-api#705
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
doc: fix support bigint64/biguint64 guards
fa79966 
PR-URL: nodejs/node-addon-api#705
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
austinli64 added a commit to austinli64/node-addon-api that referenced this pull request May 9, 2023
@austinli64
doc: fix support bigint64/biguint64 guards
4a2f339 
PR-URL: nodejs/node-addon-api#705
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
doc: fix support bigint64/biguint64 guards
e80b648 
PR-URL: nodejs/node-addon-api#705
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickNaso NickNaso NickNaso approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@legendecas legendecas legendecas approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fs-eire @mhdawson @NickNaso @gabrielschulhof @legendecas