Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add instance data APIs #708

Closed

Conversation

gabrielschulhof
Copy link
Contributor

No description provided.

Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think to use the complete namespace like we tried to do all over the rest fo the documentation? Es. Napi::Env::YOUR-METHOD

@mhdawson mhdawson mentioned this pull request Apr 27, 2020
8 tasks
@NickNaso NickNaso added the doc label Apr 27, 2020
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like GetInstanceData doesn't get documented here?

@NickNaso
Copy link
Member

@gabrielschulhof Do you have time to work on this PR? I need to insert this documentation on the new release.

@gabrielschulhof
Copy link
Contributor Author

D'oh! I forgot GetInstanceData 🤦 Sorry!

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Re: nodejs#567 (comment)
@gabrielschulhof
Copy link
Contributor Author

@NickNaso @legendecas @mhdawson I added the docs for GetInstanceData.

Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gabrielschulhof pushed a commit that referenced this pull request May 4, 2020
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Re: #567 (comment)
PR-URL: #708
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@gabrielschulhof
Copy link
Contributor Author

Landed in 381c0da.

@gabrielschulhof gabrielschulhof deleted the add-instance-data-doc branch August 6, 2020 17:32
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Re: nodejs/node-addon-api#567 (comment)
PR-URL: nodejs/node-addon-api#708
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Re: nodejs/node-addon-api#567 (comment)
PR-URL: nodejs/node-addon-api#708
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Re: nodejs/node-addon-api#567 (comment)
PR-URL: nodejs/node-addon-api#708
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
austinli64 added a commit to austinli64/node-addon-api that referenced this pull request May 9, 2023
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Re: nodejs/node-addon-api#567 (comment)
PR-URL: nodejs/node-addon-api#708
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Re: nodejs/node-addon-api#567 (comment)
PR-URL: nodejs/node-addon-api#708
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants