test: refactor remove repeated execution index.js #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaisinTen
force-pushed
the
test/refactor-to-remove-repetition-index.js
branch
3 times, most recently
from
f03f433
to
c472036
Compare
|
Can someone please review this? |
|
@RaisinTen maybe you can come to the N-API team meeting this Friday to walk us through it. It's a "nice to have" and obviously nobody has had time to get around to it so that might help move it forward. |
|
@mhdawson that would be great! I plan to join the Hangouts link. Is that okay? :) |
|
@RaisinTen absolutely (although its zoom). Just in case you need it: https://zoom.us/j/363665824 |
|
@RaisinTen and to be 100% clear, the only option is zoom even though there are other links in the calendar entry, I've just updated it so that its clearer that they are generally not used. |
|
@mhdawson thank you for updating it. Looking forward to the meet. |
|
@mhdawson I was a little confused about the timing. Is the node calendar timing yet to be updated? |
|
The calendar time should be correct. 11:00 ET |
|
@mhdawson hmm, when I saved the event to my calendar, it showed the correct time indeed. However, the time shown at nodejs.org/calendar is still different. What time standard does it follow? |
Since the only job of the main thread is to supply the correct command-line args to the child thread, here is a refactor to do just that. The generation and execution of the `testModule` is done by the child thread.
RaisinTen
force-pushed
the
test/refactor-to-remove-repetition-index.js
branch
from
c472036
to
451d418
Compare
gabrielschulhof
approved these changes
Jan 8, 2021
mhdawson
pushed a commit
that referenced
this pull request
Jan 8, 2021
Since the only job of the main thread is to supply the correct command-line args to the child thread, here is a refactor to do just that. The generation and execution of the `testModule` is done by the child thread. PR-URL: #839 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
|
Landed as 744705f |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Since the only job of the main thread is to supply the correct command-line args to the child thread, here is a refactor to do just that. The generation and execution of the `testModule` is done by the child thread. PR-URL: nodejs/node-addon-api#839 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Since the only job of the main thread is to supply the correct command-line args to the child thread, here is a refactor to do just that. The generation and execution of the `testModule` is done by the child thread. PR-URL: nodejs/node-addon-api#839 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Since the only job of the main thread is to supply the correct command-line args to the child thread, here is a refactor to do just that. The generation and execution of the `testModule` is done by the child thread. PR-URL: nodejs/node-addon-api#839 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
austinli64
added a commit
to austinli64/node-addon-api
that referenced
this pull request
May 9, 2023
Since the only job of the main thread is to supply the correct command-line args to the child thread, here is a refactor to do just that. The generation and execution of the `testModule` is done by the child thread. PR-URL: nodejs/node-addon-api#839 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Since the only job of the main thread is to supply the correct command-line args to the child thread, here is a refactor to do just that. The generation and execution of the `testModule` is done by the child thread. PR-URL: nodejs/node-addon-api#839 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the only job of the main thread is to supply the correct
command-line args to the child thread, here is a refactor to do
just that. The generation and execution of the
testModuleis done bythe child thread.