Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
test: address 2 new failures on node-chakracore
Browse files Browse the repository at this point in the history
parallel/test-debugger-util-regression
  => debugger test, disable

sequential/test-process-warnings
  => different stack trace message

PR-URL: #46
Reviewed-By: Sandeep Agarwal <Agarwal.Sandeep@microsoft.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information
Jianchun Xu committed Mar 28, 2016
1 parent 88dc654 commit 2723d94
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
6 changes: 6 additions & 0 deletions test/parallel/test-debugger-util-regression.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ const assert = require('assert');

const common = require('../common');

if (common.isChakraEngine) {
console.log('1..0 # Skipped: This test is disabled for chakra engine ' +
'because debugger support is not implemented yet.');
return;
}

const fixture = path.join(
common.fixturesDir,
'debugger-util-regression-fixture.js'
Expand Down
7 changes: 5 additions & 2 deletions test/sequential/test-process-warnings.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

require('../common');
const common = require('../common');
const assert = require('assert');
const execFile = require('child_process').execFile;
const warnmod = require.resolve('../fixtures/warnings.js');
Expand Down Expand Up @@ -29,5 +29,8 @@ execFile(node, traceWarn, function(er, stdout, stderr) {
assert.equal(er, null);
assert.equal(stdout, '');
assert(/^\(.+\)\sWarning: a bad practice warning/.test(stderr));
assert(/at Object\.\<anonymous\>\s\(.+warnings.js:3:9\)/.test(stderr));
assert(common.engineSpecificMessage({
v8: /at Object\.\<anonymous\>\s\(.+warnings.js:3:9\)/,
chakracore:/at Anonymous function\s\(.+warnings.js:3:1\)/
}).test(stderr));
});

0 comments on commit 2723d94

Please sign in to comment.