This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
ttd: fixing ttd hooks in node_file #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfarnung
approved these changes
Feb 7, 2018
|
nit: In this case the "subsystem" is actually "fs" or more broadly "src." since "ttd" isn't really a subsystem that's being modified here. EDIT: I tend to use this as my defacto list of subsystems: https://github.com/nodejs/core-validate-commit/blob/master/lib/rules/subsystem.js |
MSLaguana
force-pushed
the
fixFsReadTTD
branch
from
d6e85ee
to
e0e89be
Compare
MSLaguana
added a commit
to MSLaguana/node-chakracore
that referenced
this pull request
Feb 9, 2018
Some refactoring had caused TTD to fail whenever node::fs::AfterInteger was called for a reason other than node::fs::Read. PR-URL: nodejs#461 Reviewed-By: Mike Kaufman <mike.kaufman@microsoft.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Some refactoring had caused TTD to fail whenever node::fs::AfterInteger was called for a reason other than node::fs::Read. PR-URL: nodejs#461 Reviewed-By: Mike Kaufman <mike.kaufman@microsoft.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
MSLaguana
force-pushed
the
fixFsReadTTD
branch
from
e0e89be
to
f162a30
Compare
|
Thanks everyone! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactoring had caused TTD to fail whenever node::fs::AfterInteger
was called for a reason other than node::fs::Read.
Also moving the TTD component outside of the
after.Proceedcheck to make sure that we always report the end of the period where libuv would be writing to the buffer.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
ttd