This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
test: cleanup chakracore customization #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSLaguana
reviewed
Jul 30, 2018
| @@ -21,4 +21,4 @@ async function runTests() { | |||
| assert.strictEqual(0, (await instance.expectShutdown()).exitCode); | |||
| } | |||
|
|
|||
| runTests().catch((err) => { console.log(err); process.exit(-1); }); | |||
There was a problem hiding this comment.
Is this just to make us the same as upstream? I believe that we added this because without it, if the test fails it is often via a timeout with no additional information. I suppose we should just upstream that change though.
There was a problem hiding this comment.
I believe this was actually a problem before we had unhandled promise rejection handling. It should correctly print the unhandled rejection and exit with an error now.
There was a problem hiding this comment.
Looks like it should do the right thing:
> .\Release\node.exe --expose-internals .\test\sequential\test-inspector-break-e.js
[test] Connecting to a child Node process
[test] Testing /json/list
[err] Debugger listening on ws://127.0.0.1:2957/8bb3dc33-f1f0-43be-98f3-f36d7e0e68d0
[err] For help, see: https://nodejs.org/en/docs/inspector
[err]
[err] Debugger attached.
[err]
Error: foo
at runTests (E:\GitHub\node-chakracore\test\sequential\test-inspector-break-e.js:19:3)
at Generator.prototype.next (native code)
at _tickCallback (internal/process/next_tick.js:68:7)
1
> $LASTEXITCODE
1
MSLaguana
approved these changes
Jul 30, 2018
* Undo obsolete test modifications and enable more tests. * Remove unnecessary deltas with upstream * Fix lint issues PR-URL: nodejs#580 Reviewed-By: Seth Brenith <sethb@microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
|
It looks like |
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Aug 6, 2018
* Undo obsolete test modifications and enable more tests. * Remove unnecessary deltas with upstream * Fix lint issues PR-URL: nodejs#580 Reviewed-By: Seth Brenith <sethb@microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undo obsolete test modifications and enable more tests.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes