fix: run release script asynchronously

nodejs · May 4, 2020 · 42a9d9f · 42a9d9f
1 parent 6686d07
commit 42a9d9f
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/promote_release.js b/lib/promote_release.js
@@ -5,7 +5,7 @@ const { promises: fs } = require('fs');
 const semver = require('semver');
 
 const { getMergedConfig } = require('./config');
-const { runSync } = require('./run');
+const { runSync, runAsync } = require('./run');
 const auth = require('./auth');
 const PRData = require('./pr_data');
 const PRChecker = require('./pr_checker');
@@ -151,7 +151,7 @@ class ReleasePromotion {
     const keyPath = await cli.prompt(
       `Please enter the path to your ssh key (Default ${defaultKeyPath}): `,
       { questionType: 'input', defaultAnswer: defaultKeyPath });
-    this.promoteAndSignRelease(keyPath);
+    await this.promoteAndSignRelease(keyPath);
 
     cli.separator();
     cli.ok(`Release promotion for ${version} complete.\n`);
@@ -313,8 +313,8 @@ class ReleasePromotion {
     return runSync('git', ['push', 'upstream', tagVersion]);
   }
 
-  promoteAndSignRelease(keyPath) {
-    return runSync('./tools/release.sh', ['-i', keyPath]);
+  async promoteAndSignRelease(keyPath) {
+    await runAsync('./tools/release.sh', ['-i', keyPath]);
   }
 
   cherryPickToMaster() {