Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse ci failure error #640

Merged
merged 1 commit into from
Jul 30, 2022
Merged

Conversation

F3n67u
Copy link
Member

@F3n67u F3n67u commented Jul 11, 2022

fix #639

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #640 (4cdb536) into main (460b50d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #640   +/-   ##
=======================================
  Coverage   84.09%   84.09%           
=======================================
  Files          37       37           
  Lines        4074     4074           
=======================================
  Hits         3426     3426           
  Misses        648      648           
Impacted Files Coverage Δ
lib/ci/ci_failure_parser.js 85.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 460b50d...4cdb536. Read the comment docs.

@F3n67u F3n67u marked this pull request as draft July 11, 2022 11:14
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@F3n67u
Copy link
Member Author

F3n67u commented Jul 11, 2022

I will add a test for this fix.

@F3n67u
Copy link
Member Author

F3n67u commented Jul 11, 2022

LGTM, probably best to add a test here? https://github.com/nodejs/node-core-utils/blob/main/test/unit/ci_failure_parser.test.js

of course. I am working on the test. this is why this pr is a draft.😀

@F3n67u F3n67u force-pushed the fix/js-test-failure-match branch 3 times, most recently from de00536 to 75ef933 Compare July 11, 2022 12:30
@F3n67u F3n67u marked this pull request as ready for review July 11, 2022 12:31
@F3n67u F3n67u requested a review from codebytere July 11, 2022 12:31
@F3n67u
Copy link
Member Author

F3n67u commented Jul 11, 2022

I added a test for the fix, please take another look.

@F3n67u F3n67u force-pushed the fix/js-test-failure-match branch from acaf341 to 3c634d6 Compare July 11, 2022 14:34
@F3n67u F3n67u force-pushed the fix/js-test-failure-match branch from 3c634d6 to 4cdb536 Compare July 12, 2022 14:04
@F3n67u F3n67u requested a review from aduh95 July 12, 2022 14:05
@F3n67u
Copy link
Member Author

F3n67u commented Jul 13, 2022

@aduh95 could you help to merge this pr?

@F3n67u
Copy link
Member Author

F3n67u commented Jul 30, 2022

Update CI reliability job stop working again, please help to merge this pr, Thank you! https://github.com/nodejs/reliability/runs/7587812485?check_suite_focus=true cc @nodejs/node-core-utils

@aduh95 aduh95 merged commit 0d49eda into nodejs:main Jul 30, 2022
@F3n67u F3n67u deleted the fix/js-test-failure-match branch July 30, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ncu-ci commit TypeError: Cannot read properties of null (reading '1')
4 participants