Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(git-node): add support for the --gpg-sign git flag #684

Merged
merged 2 commits into from
Mar 18, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 8, 2023

I've also extended the max line length from 80 to 100 as it was making less readable to keep it at 80 IMO.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b9c443b) 83.45% compared to head (191513b) 83.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #684   +/-   ##
=======================================
  Coverage   83.45%   83.45%           
=======================================
  Files          37       37           
  Lines        4158     4158           
=======================================
  Hits         3470     3470           
  Misses        688      688           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aduh95
Copy link
Contributor Author

aduh95 commented Mar 18, 2023

ping @nodejs/node-core-utils

@targos
Copy link
Member

targos commented Mar 18, 2023

I personally set this in my git config. What's the advantage of this flag compared to it ?

@aduh95
Copy link
Contributor Author

aduh95 commented Mar 18, 2023

The flag let's you select a specific keyid to sign the commit with.

@targos
Copy link
Member

targos commented Mar 18, 2023

In the git config you can set ˋuser.signingkey` with the key id

@aduh95
Copy link
Contributor Author

aduh95 commented Mar 18, 2023

If you have set a specific key id in your git config, the flag lets you specify a different one.

@targos
Copy link
Member

targos commented Mar 18, 2023

I still don't understand the use case. Don't you always use the same key for the node repo?

@aduh95
Copy link
Contributor Author

aduh95 commented Mar 18, 2023

No, I usually don't sign my commits for the node repo (why would I, the CQ would sign them for me), but in the rare cases when I need to push manually to main, I have to do the git commit --amend --no-edit -S dance, and it seems easy to add the flag to ncu instead.

@aduh95 aduh95 merged commit 92d621e into nodejs:main Mar 18, 2023
@aduh95 aduh95 deleted the gpg-sign branch March 18, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants