Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

land: fix --abort exit status code #449

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

mmarchini
Copy link
Contributor

--abort shouldn't exit with error status code unless something goes
wrong.

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #449 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #449   +/-   ##
=======================================
  Coverage   77.08%   77.08%           
=======================================
  Files          21       21           
  Lines        1497     1497           
=======================================
  Hits         1154     1154           
  Misses        343      343           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8c024d...fe9b2ba. Read the comment docs.

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one spelling fix but otherwise lgtm :)

lib/landing_session.js Outdated Show resolved Hide resolved
`--abort` shouldn't exit with error status code unless something goes
wrong.
@codebytere codebytere merged commit aac20a6 into nodejs:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants