Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): revert to node-fetch #595

Merged
merged 1 commit into from
Nov 17, 2021
Merged

fix(deps): revert to node-fetch #595

merged 1 commit into from
Nov 17, 2021

Conversation

codebytere
Copy link
Member

Closes #594.

@codebytere codebytere mentioned this pull request Nov 17, 2021
Closed
targos
targos approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "fix" in the commit message otherwise it won't generate a release PR

@codecov
Copy link

codecov bot commented Nov 17, 2021 •
edited

Codecov Report

Merging #595 (84a8694) into main (a571938) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   80.19%   80.19%           
=======================================
  Files          37       37           
  Lines        1828     1828           
=======================================
  Hits         1466     1466           
  Misses        362      362

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a571938...84a8694. Read the comment docs.

@codebytere codebytere changed the title chore(deps): revert to node-fetch fix(deps): revert to node-fetch Nov 17, 2021
@targos targos merged commit e475060 into nodejs:main Nov 17, 2021
@targos targos mentioned this pull request Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@ronag ronag Awaiting requested review from ronag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: fetch is not a function
2 participants
@codebytere @targos