Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update maintaining-dependencies.md on major v8 update #699

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

fasenderos
Copy link
Contributor

Update doc/contributing/maintaining/maintaining-dependencies.md on major V8 updates. Marked as draft in order to wait for nodejs/node#48081 to land

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ecb1b7d) 83.38% compared to head (d4e53e5) 83.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #699   +/-   ##
=======================================
  Coverage   83.38%   83.38%           
=======================================
  Files          37       37           
  Lines        4158     4158           
=======================================
  Hits         3467     3467           
  Misses        691      691           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@targos
Copy link
Member

targos commented Jun 1, 2023

Thanks for the PR! The changes look good to me, but unfortunately we can't do them in updateVersionNumbers because it won't end up in the right commit (this task is very specific and creates the commit src: update NODE_MODULE_VERSION to XXX).

Could you move the code to a new task that is run between majorUpdate and commitUpdate in index.js? It would need to make the change and git add it.

@fasenderos fasenderos changed the title docs: update maintaining-dependencies.md on major update docs: update maintaining-dependencies.md on major v8 update Jun 1, 2023
@fasenderos
Copy link
Contributor Author

@targos I have moved the task between majorUpdate and commitUpdate. I'm not familiar with this repo hope it's ok

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thank you!

@marco-ippolito
Copy link
Member

landed nodejs/node#48081

@fasenderos fasenderos marked this pull request as ready for review June 6, 2023 09:19
@targos targos merged commit a8b1812 into nodejs:main Jun 7, 2023
16 checks passed
targos added a commit that referenced this pull request Dec 21, 2023
targos added a commit that referenced this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants