Skip to content

Commit

Permalink
gyp: list(dict) so we can del dict(key) while iterating
Browse files Browse the repository at this point in the history
Fixes #1998

Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: #2009
  • Loading branch information
cclauss authored and rvagg committed Jan 6, 2020
1 parent 26cd6ea commit 14f2a07
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gyp/pylib/gyp/input.py
Original file line number Diff line number Diff line change
Expand Up @@ -2286,7 +2286,7 @@ def SetUpConfigurations(target, target_dict):
merged_configurations[configuration])

# Now drop all the abstract ones.
for configuration in target_dict['configurations'].keys():
for configuration in list(target_dict['configurations']):
old_configuration_dict = target_dict['configurations'][configuration]
if old_configuration_dict.get('abstract'):
del target_dict['configurations'][configuration]
Expand Down

0 comments on commit 14f2a07

Please sign in to comment.