Fix deprecated dependency warning #1069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
approved these changes
Dec 12, 2016
There was a problem hiding this comment.
Thanks, LGTM. CI: https://ci.nodejs.org/view/All/job/nodegyp-test-commit/34/
Fishrock123
pushed a commit
that referenced
this pull request
Dec 15, 2016
Refs: https://github.com/iarna/gauge/pull/77 PR-URL: #1069 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
Thanks, landed in 80fc5c3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-gyp installs npmlog@3.1.2
npmlog@3.1.2 installs gauge@2.6.0
gauge@2.6.0 uses has-color@0.1.7 that is been ranamed to supports-color
The warning is not showed if we tell node-gyp to use npmlog@4.0.1
npmlog@4.0.1 installs gauge@2.7.2 that fix the dependency warnings.
See https://github.com/iarna/gauge/pull/77