Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log dist-url. #1170

Merged
merged 1 commit into from May 17, 2017
Merged

Log dist-url. #1170

merged 1 commit into from May 17, 2017

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Apr 11, 2017 •
edited

The default download URL can be overridden by --dist-url or one of the
*_MIRROR environment variables. Log the URL to ease troubleshooting.

Fixes: #1169
CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/8/

@bnoordhuis bnoordhuis mentioned this pull request Apr 11, 2017
Closed
@Fishrock123
Copy link
Member

seems like a good idea

@bnoordhuis
Copy link
Member Author

@Fishrock123 Can I take your comment as a LGTM?

@bnoordhuis
Log dist-url.
241752f 
The default download URL can be overridden by `--dist-url` or one of the
`*_MIRROR` environment variables.  Log the URL to ease troubleshooting.

Fixes: #1169
PR-URL: #1170
Reviewed-By: Refael Ackermann <refack@gmail.com>
@bnoordhuis bnoordhuis closed this May 17, 2017
@bnoordhuis bnoordhuis deleted the log-dist-url branch May 17, 2017 09:36
@bnoordhuis bnoordhuis merged commit 241752f into nodejs:master May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bnoordhuis @Fishrock123 @refack