Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: rename copyNodeLib() to doBuild() #1206

Closed
wants to merge 1 commit into from
Closed

build: rename copyNodeLib() to doBuild() #1206

wants to merge 1 commit into from

Conversation

lc-soft
Copy link
Contributor

@lc-soft lc-soft commented May 22, 2017 •
edited
Loading

@refack
I use the npm test command to run the test, unfortunately, the test does not pass, in which there is a error message:

...
gyp verb node dev dir C:\Users\鍒樿秴\.node-gyp\6.3.1
gyp verb found first Solution file build/binding.sln
gyp verb using MSBuild: D:\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\MSBuild.exe
gyp ERR! UNCAUGHT EXCEPTION
gyp ERR! stack ReferenceError: copyNodeLib is not defined
gyp ERR! stack     at findMsbuild (F:\浠ｇ爜搴揬GitHub\node-gyp\lib\build.js:127:7)
gyp ERR! stack     at F:\浠ｇ爜搴揬GitHub\node-gyp\lib\build.js:107:11
gyp ERR! stack     at F (F:\浠ｇ爜搴揬GitHub\node-gyp\node_modules\.1.2.14@which\which.js:68:16)
gyp ERR! stack     at E (F:\浠ｇ爜搴揬GitHub\node-gyp\node_modules\.1.2.14@which\which.js:80:29)
gyp ERR! stack     at F:\浠ｇ爜搴揬GitHub\node-gyp\node_modules\.1.2.14@which\which.js:89:16
gyp ERR! stack     at F:\浠ｇ爜搴揬GitHub\node-gyp\node_modules\.2.0.0@isexe\index.js:42:5
gyp ERR! stack     at F:\浠ｇ爜搴揬GitHub\node-gyp\node_modules\.2.0.0@isexe\windows.js:36:5
gyp ERR! stack     at FSReqWrap.oncomplete (fs.js:123:15)
gyp ERR! System Windows_NT 10.0.14393
gyp ERR! command "D:\\nodejs\\node.exe" "F:\\浠ｇ爜搴揬\GitHub\\node-gyp\\bin\\node-gyp.js" "rebuild" "-C" "F:\\浠ｇ爜搴揬\GitHub\\node-gyp\\test\\node_modules\\hello_world" "--loglevel=verbose"
gyp ERR! cwd F:\浠ｇ爜搴揬GitHub\node-gyp\test\node_modules\hello_world
gyp ERR! node -v v6.3.1
gyp ERR! node-gyp -v v3.6.1
gyp ERR! This is a bug in `node-gyp`.
gyp ERR! Try to update node-gyp and file an Issue if it does not help:
gyp ERR!     <https://github.com/nodejs/node-gyp/issues>
...

copyNodeLib() is not defined, I searched the entire file directory and did not find the definition of copyNodeLib().

Finally, I found this commit after browsing commits history, and the author did not rename all copyNodeLib() to doBuild(), so I added this change.

ps. output message encoding is incorrect.

refack
refack approved these changes May 22, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@refack
Copy link
Contributor

refack commented May 22, 2017

Good catch!

@refack refack self-assigned this May 22, 2017
refack pushed a commit that referenced this pull request May 27, 2017
@lc-soft @refack
build: rename copyNodeLib() to doBuild()
72afdd6 
PR-URL: #1206
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@refack
Copy link
Contributor

refack commented May 27, 2017

Landed in 72afdd6

@refack refack closed this May 27, 2017
@refack
Copy link
Contributor

refack commented May 27, 2017

Post land CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/17/

@refack refack mentioned this pull request May 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@joaocgreis joaocgreis joaocgreis approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees

@refack refack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lc-soft @refack @joaocgreis @gibfahn