Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.x: Add Python 3.5 and 3.6 tests on Linux #1909

Closed
wants to merge 2 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 3, 2019

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

As requested at #1905 (comment) this PR features #1903 -like changes but this PR is based on the v5.x branch and is intended to land in the v5.0.5 release.

The Travis changes mean that we are now testing on Python 2.7, 3.5, 3.6, and 3.7 os on Unix and macOS we will support all four. On Windows, we are not recommending the use of Micorsoft's Python so this release will only support legacy Python on Windows.

@cclauss cclauss changed the base branch from master to v5.x October 3, 2019 16:08
Copy link
Contributor

@sam-github sam-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a backport of #1903 to 5.x, I think, but it shouldn't contain the docs, they don't seem applicable.

README.md Outdated Show resolved Hide resolved
@joaocgreis
Copy link
Member

@cclauss the point of keeping a v5.x branch is to keep it like the current published version, accepting only Python 2. Or am I missing something?

Here, it makes sense to add testing to Travis. its behind the EXPERIMENTAL_NODE_GYP_PYTHON3 flag and helps ensuring that we don't land anything on v5.x that would leave us in a tight spot.

However, the README changes look wrong - Python 3 is not supported here, and it's not supposed to be. Unless I'm wrong, the README changes should be removed from this PR.

@cclauss
Copy link
Contributor Author

cclauss commented Oct 3, 2019

Reverted all changes to README.md.

Copy link
Member

@joaocgreis joaocgreis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending CI and Travis

@joaocgreis
Copy link
Member

rvagg pushed a commit that referenced this pull request Oct 4, 2019
PR-URL: #1909
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
@rvagg
Copy link
Member

rvagg commented Oct 4, 2019

fantastic, landed in 3834156

@rvagg rvagg closed this Oct 4, 2019
@cclauss cclauss deleted the Travis-CI-add-Python-3.5-and-3.6 branch October 4, 2019 03:45
@cclauss cclauss added the Python label Oct 4, 2019
@rvagg rvagg mentioned this pull request Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants