Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove npm install because it uses legacy Python #2014

Closed
wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 5, 2020

Fixes #1977 (comment)

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@sam-github
Copy link
Contributor

What does this fix? Is there a nodejs or https://github.com/felixrieseberg/windows-build-tools/issues bug it refers to?

The manual install of C++ build tools is pretty finicky. /cc @gireeshpunathil who has helped people work through issues with Windows setup a fair bit.

@cclauss
Copy link
Contributor Author

cclauss commented Jan 5, 2020

Fixes: #1977 (comment)

@just-boris
Copy link

@sam-github this can serve as a relevant report in the other package: felixrieseberg/windows-build-tools#191 (comment)

@sam-github
Copy link
Contributor

Is this obsoleted by felixrieseberg/windows-build-tools#205 @cclauss ?

@cclauss
Copy link
Contributor Author

cclauss commented Jan 6, 2020

That PR currently fails its tests and I do not know how to get them to pass. If it did pass those tests and was merged then we could close this PR without merging these changes.

@richardlau
Copy link
Member

That PR currently fails its tests and I do not know how to get them to pass. If it did pass those tests and was merged then we could close this PR without merging these changes.

I think you'll need to remove the check for ' 2.' in https://github.com/felixrieseberg/windows-build-tools/blob/b4c681c770fa429734e45600906b4271421e1328/src/utils/get-is-python-installed.ts#L13-L17

@rvagg
Copy link
Member

rvagg commented Feb 3, 2020

I'm uncertain of the status here, it seems like it might have been made redundant? that file now checks for 3. https://github.com/felixrieseberg/windows-build-tools/blob/master/src/utils/get-is-python-installed.ts#L13-L17, I suppose that's better

@cclauss cclauss closed this Feb 3, 2020
@cclauss cclauss deleted the npm-uses-legacy-Python branch February 3, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Still need Python2 to run node-gyp v5.0.3
5 participants