Adding tarfile member sanitization to extractall()

[Trott]

From nodejs/node#44823:

Patching CVE-2007-4559

Hi, we are security researchers from the Advanced Research Center at Trellix. We have began a campaign to patch a widespread bug named CVE-2007-4559. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar file could perform a directory path traversal attack. We found at least one unsantized extractall() in your codebase and are providing a patch for you via pull request. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. We encourage you to use this patch or your own solution to secure against CVE-2007-4559. Further technical information about the vulnerability can be found in this blog.

If you have further questions you may contact us through this projects lead researcher Kasimir Schulz.

@TrellixVulnTeam

[rvagg]

sure, seems straightforward if a little unnecessary given this is only grabbing from github but if it stops people reporting security problems then that's good

[targos]

Maybe I'm missing something but this change breaks the script on my mac:

$ ./update-gyp.py v0.14.0
Downloading gyp-next@v0.14.0 into temporary directory...
From: https://github.com/nodejs/gyp-next/archive/v0.14.0.tar.gz
Unzipping...
Traceback (most recent call last):
  File "/Users/targos/git/nodejs/node-gyp/./update-gyp.py", line 54, in <module>
    safe_extract(tar_ref, unzip_target)
  File "/Users/targos/git/nodejs/node-gyp/./update-gyp.py", line 52, in safe_extract
    tar.extractall(path, members, numeric_owner)
TypeError: TarFile.extractall() takes from 1 to 3 positional arguments but 4 were given

[TrellixVulnTeam]

I submitted another PR that changed numeric_owner as a keyword argument. That will support Python 3.5 or higher.

[cclauss]

@targos python --version ?

[cclauss]

The asterisk is significant here.

[cclauss]

https://docs.python.org/3/library/tarfile.html#tarfile.TarFile.extract
This must be tar.extractall(path, members, numeric_owner=numeric_owner)

[targos]

@cclauss

$ python --version
Python 3.10.7