Detect visual studio installation using VSSetup module #2957
Conversation
jarig
force-pushed
the
feat/vs-detection-improve
branch
2 times, most recently
from
0993aa5
to
d54e550
Compare
jarig
force-pushed
the
feat/vs-detection-improve
branch
2 times, most recently
from
c2eb63c
to
4195a9e
Compare
|
Verified tests on both windows and linux now |
jarig
force-pushed
the
feat/vs-detection-improve
branch
from
4195a9e
to
4590adf
Compare
|
Sry last linting issue also fixed. Btw mind to add |
|
@cclauss any other activities or blockers to be done for the PR merge? |
There was a problem hiding this comment.
The PR looks good overall. I have another PR that works on the same parts of the code, so this one should land first as my changes should be in the new findVisualStudio2017OrNewerUsingSetupModule function as well. I can rebase my changes on top of this one after it lands.
I've noticed something with the tests here though. There are no VSSetup files in fixtures for all of the fixtures we had before. The problem with it is that in our tests we will simulate the VSSetup function to return null when it should return something (eg. having 2019 installed). I'm aware this would be a tedious task to make all those fixtures and I'm not sure it's worth the effort, but just wanted to bring it up in case it comes up later.
…VSSetupInstance method, it works even in systems with Constrained language mode of the powershell
jarig
force-pushed
the
feat/vs-detection-improve
branch
from
4590adf
to
a7f2c2b
Compare
There was a problem hiding this comment.
The changes LGTM. Thanks for addressing my comments @jarig. @lukekarrys (since you are a reviewer) if this LGTY too we can go ahead and merge this and I'll rebase and adapt my changes in #2959 accordingly.
|
I plan to land this tomorrow. If there are any concerns, please state them today. cc @lukekarrys |
|
Good! |
Checklist
npm install && npm run lint && npm testpassesDescription of change
Detect visual studio installation using VSSetup module and Get-VSSetupInstance method as a first attempt, this approach works even in systems with Constrained language mode of the powershell.
Original type-base detection requires
FullLanguagemode, which quite often not available on the enrolled devices.