Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gyp to b3cef02. #831

Merged
merged 1 commit into from
Dec 3, 2015
Merged

Upgrade gyp to b3cef02. #831

merged 1 commit into from
Dec 3, 2015

Conversation

bnoordhuis
Copy link
Member

Fixes: #571
Fixes: #803

R=@rvagg?

@Fishrock123
Copy link
Member

Rubber-stamp LGTM, people have been having trouble on those systems for some time due to this.

* adds netbsd support: https://codereview.chromium.org/1421073004

* fixes cp(1) use on openbsd: https://codereview.chromium.org/1483473002

Fixes: #571
Fixes: #803
PR-URL: #831
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@bnoordhuis bnoordhuis merged commit ab89b47 into nodejs:master Dec 3, 2015
@bnoordhuis bnoordhuis deleted the upgrade-gyp branch December 3, 2015 01:34
@bnoordhuis
Copy link
Member Author

Published as v3.2.1.

othiym23 added a commit to npm/npm that referenced this pull request Dec 3, 2015
Improved *BSD support.

Credit: @bnoordhuis
Reviewed-By: @othiym23
PR-URL: nodejs/node-gyp#831
othiym23 added a commit to npm/npm that referenced this pull request Dec 4, 2015
Improved *BSD support.

Credit: @bnoordhuis
Reviewed-By: @othiym23
PR-URL: nodejs/node-gyp#831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use standard cp arguments
2 participants