More verbose error on locating msbuild.exe failure #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but you show up as "purplecode" in the commit's Author field. Want me to land it under your real name? Also, if you can reword the commit log so it conforms a bit better to the general format we use, that would be great. |
|
I rewrote the author field and commit message in my commit |
purplecode
changed the title
purplecode
changed the title
bnoordhuis
pushed a commit
that referenced
this pull request
Jun 2, 2016
PR-URL: #930 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Thanks Mateusz, landed in a4fa07b. I massaged the commit log's status line so it fit in 50 columns. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first error usage was misleading. In my case the error was saying 'Access denied' and it was because of limited privileges, not because of missing VS installation. It was also hard to debug because one of the deeply nested dependencies was failing.