Try python launcher when stock python is python 3. #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://ci.nodejs.org/view/All/job/nodegyp-test-commit/8/nodes=win2012r2/console - building the test add-on fails but I don't think it's related to this PR. Let's see what a CI run of master does: https://ci.nodejs.org/view/All/job/nodegyp-test-commit/10/ |
|
ack |
|
Rebased, new CI: https://ci.nodejs.org/view/All/job/nodegyp-test-commit/31/ @rvagg Was your ACK an implicit LGTM or an 'I am aware this pull request exists'? |
|
LGTM |
Break up findPython() into pieces that can be tested in isolation and add tests that do so. PR-URL: #992 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #987 (comment). Add lots and lots of tests that verify all code paths.
R=@rvagg?
CI: https://ci.nodejs.org/view/All/job/nodegyp-test-commit/8/