Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Use pkgjs/action for CI to auto-upgrade to latest nodes #106

Closed
dominykas opened this issue Jan 31, 2022 · 2 comments
Closed

Use pkgjs/action for CI to auto-upgrade to latest nodes #106

dominykas opened this issue Jan 31, 2022 · 2 comments

Comments

@dominykas
Copy link
Member

The CI workflow used here is almost identical to a standard Node.js library testing pattern (checkout, npm install, npm test).

As part of Package Maintenance WG, I've recently created pkgjs/action - it basically does that standard Node testing pattern, but it automatically maintains the test matrix for you, i.e. it will automatically detect the lowest supported (major) version from engines field and will automatically add new Node.js versions as they come out.

As the action is pretty new, I'd like to get some battle testing for it.

Would people mind if I opened a PR to start using it here? I'm willing to take on the maintenance of that until we feel it's stable.

The end result here would probably look something like this: https://github.com/pkgjs/action/blob/main/.github/workflows/ci.yaml

@jkrems
Copy link
Collaborator

jkrems commented Jan 31, 2022

That's really cool! Normally I would say "sure, let's try it here" but unfortunately node-inspect is effectively archived since the code was moved into node core.

Looks like the only thing that prevents us from archiving the repo right now is doing some triage on the remaining open issues (see https://github.com/nodejs/node/discussions/36481).

@dominykas
Copy link
Member Author

👍

Thanks. I guess this can be closed, so you won't have to triage it ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants