Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

refactor: remove unused timeout parameter in portIsFree #92

Closed

Conversation

copperwall
Copy link

timeout is specified as an optional parameter with a default value of
9999. portIsFree doesn't have any callsites that use this optional
parameter, so this removes the parameter and leaves the timeout value as
a local variable in the function. portIsFree isn't exported outside of
_inspect.js, so this doesn't change any public function interfaces.

`timeout` is specified as an optional parameter with a default value of
`9999`. `portIsFree` doesn't have any callsites that use this optional
parameter, so this removes the parameter and leaves the timeout value as
a local variable in the function. `portIsFree` isn't exported outside of
`_inspect.js`, so this doesn't change any public function interfaces.
@Trott
Copy link
Member

Trott commented Jun 19, 2021

Hi, there! node-inspect is now part of Node.js core. If you want to open a PR for this in the main repository, I'd be supportive of the change. The relevant file is in lib/internal/inspector/_inspect.js although there is a PR open to move it to lib/internal/debugger/_inspect.js so if that previous file is missing, look for that latter file.

In the meantime, this repository is being tidied up in preparation for archiving, so I'm going to close this PR. Sorry it didn't land back when you opened it!

@Trott Trott closed this Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants