Skip to content
This repository has been archived by the owner on Jun 18, 2021. It is now read-only.

Update tap to version 14.3.1 #135

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,4 @@ node-report*.txt
npm-debug.log
nodereport-*.tgz
nodereport_test.log
package-lock.json
1 change: 1 addition & 0 deletions .taprc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
esm: false
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"url": "https://github.com/nodejs/node-report/issues"
},
"devDependencies": {
"tap": "~12.4.1"
"tap": "^14.3.1"
}
}
6 changes: 6 additions & 0 deletions test/test-api-getreport.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ if (process.argv[2] === 'child') {
'Checking no messages on stderr');
const reportFiles = common.findReports(child.pid);
tap.same(reportFiles, [], 'Checking no report files were written');

// tap with coverage enabled wraps the child so adjust expected command line
if (process.env['SPAWN_WRAP_SHIM_ROOT']) {
args.unshift('.*node');
}

tap.test('Validating report content', (t) => {
common.validateContent(child.stdout, t, { pid: child.pid,
commandline: process.execPath + ' ' + args.join(' ')
Expand Down
4 changes: 4 additions & 0 deletions test/test-fatal-error.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ if (process.argv[2] === 'child') {
require('../');

const list = [];
// tap with coverage enabled installs signal handlers that prevents the
// fatal error causing the process to exit. Remove them.
process.removeAllListeners('SIGABRT');
process.removeAllListeners('SIGTRAP');
while (true) {
const record = new MyRecord();
list.push(record);
Expand Down
4 changes: 4 additions & 0 deletions test/test-signal.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ if (process.argv[2] === 'child') {
// Exit on loss of parent process
process.on('disconnect', () => process.exit(2));

// tap with coverage enabled installs signal handlers that prevents the
// signal from causing the process to exit. Remove them.
process.removeAllListeners('SIGTERM');

function busyLoop() {
var list = [];
for (var i = 0; i < 1e10; i++) {
Expand Down