Skip to content
This repository has been archived by the owner. It is now read-only.
Permalink
Browse files

dgram: handle close of dgram socket before DNS lookup completes

  • Loading branch information
mojodna authored and bnoordhuis committed Feb 14, 2012
1 parent ef032cb commit 1ce14eca44c7c3bf9812b462e1931de58d09edc3
Showing with 36 additions and 1 deletion.
  1. +1 −1 lib/dgram.js
  2. +35 −0 test/simple/test-dgram-close.js
@@ -175,7 +175,7 @@ Socket.prototype.send = function(buffer,
if (callback) callback(err);
self.emit('error', err);
}
else {
else if (self._handle) {
var req = self._handle.send(buffer, offset, length, port, ip);
if (req) {
req.oncomplete = afterSend;
@@ -0,0 +1,35 @@
// Copyright Joyent, Inc. and other Node contributors.
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the
// "Software"), to deal in the Software without restriction, including
// without limitation the rights to use, copy, modify, merge, publish,
// distribute, sublicense, and/or sell copies of the Software, and to permit
// persons to whom the Software is furnished to do so, subject to the
// following conditions:
//
// The above copyright notice and this permission notice shall be included
// in all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

// Ensure that if a dgram socket is closed before the DNS lookup completes, it
// won't crash.

var assert = require('assert'),
common = require('../common'),
dgram = require('dgram');

var buf = new Buffer(1024);
buf.fill(42);

var socket = dgram.createSocket('udp4');

socket.send(buf, 0, buf.length, common.port, 'localhost');
socket.close();

0 comments on commit 1ce14ec

Please sign in to comment.
You can’t perform that action at this time.