This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
events: fix checking max listeners with
1
Fixes #2490.
- Loading branch information
1 parent
9a79bb6
commit 22d7fe1
Showing
2 changed files
with
27 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22d7fe1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit broke
test/simple/test-event-emitter-check-listener-leaks.js
EDIT: Forgot to add 'in debug mode'.
22d7fe1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... I cannot reproduce it in my environment (Ubuntu 11.04 on VirtualBox on Windows):
In your result, the following line (
2 listeners added
) is not printed:It is printed out before assertion (by line 48):
22d7fe1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, false alarm. It turns out that waf wasn't rebuilding
out/Debug/node
. After removing said file by hand and runningmake test-debug
again, the test passes.