process.stderr.write should return true

nodejs · Mar 30, 2011 · ed74db0 · ed74db0
1 parent 6394ba2
commit ed74db0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/node_stdio.cc b/src/node_stdio.cc
@@ -165,13 +165,12 @@ static Handle<Value> IsATTY (const Arguments& args) {
 
 
 /* STDERR IS ALWAY SYNC ALWAYS UTF8 */
-static Handle<Value>
-WriteError (const Arguments& args)
-{
+static Handle<Value> WriteError (const Arguments& args) {
   HandleScope scope;
 
-  if (args.Length() < 1)
+  if (args.Length() < 1) {
     return Undefined();
+  }
 
   String::Utf8Value msg(args[0]->ToString());
 
@@ -189,7 +188,7 @@ WriteError (const Arguments& args)
     written += (size_t)r;
   }
 
-  return Undefined();
+  return True();
 }
 
 

diff --git a/test/simple/test-console.js b/test/simple/test-console.js
@@ -36,3 +36,6 @@ global.process.stdout.write = stdout_write;
 assert.equal('foo\n', strings.shift());
 assert.equal('foo bar\n', strings.shift());
 assert.equal('foo bar hop\n', strings.shift());
+
+
+assert.equal(true, process.stderr.write("hello world"));