This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Keep-alive probe interval and probe limit for keep-alives on sockets #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes should probably be offered into to joyent/libuv, not to joyent/node. |
|
Thanks AllSeeingEye. Missed the other repo. I made the changes in libuv and fixed my commit to remove the changes to deps. The libuv pull request is: joyent/libuv#269 |
|
Moving to master. New pull request: #4882 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to have the probing interval and the failure count available on sockets for keep-alive's.
Caveat: These will not work on Windows but work on Linux 2.4+.