This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Cluster 2.0 – step 2 : silent option in fork #2354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
| } | ||
|
|
||
| else { |
|
Really, I hate that coding style, but i fixed it. What is the policy if I want to comment that line? //this is a child of parent
if (isChild) {
}
//This is parent
else {
} |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ry
As discussed in the IRC i will pull the
silentoption in step 2. I also updated documentation and made a testcase.I know this can't be pushed to v0.6, but the master branch is to unstable to work in.
About step 3
fork(env)you can just pull #2042 I have no code addition to that.But @visionmedia need to update documetation, and perhaps make a testcase.
If you want I can make a step 3 too, but please inform me else i won't do it.
This is about the merging in the
cluster 2.0( see #2038 ) pull request