Incorrect default install path for x64 node .msi #5592

Closed
natecain opened this Issue May 29, 2013 · 3 comments

Projects

None yet

3 participants

Hello,

On my windows 8 laptop the 64-bit msi installers from the node download page show a default install path of "\Program Files (x86)" instead of the expected "\Program Files" path. This adds a counter-intuitive step in the install workflow, and is especially problematic when both architectures are to be installed side-by-side.

KenanY commented Aug 14, 2013

Is this still an issue? Works fine for me (v0.10.15).

It may be related to having previously installed the 32-bit version.

I just tried out both the 0.10.15 and 0.11.5 installers on both the same laptop and a similarly configured desktop and saw the same issue in both places. Both places had originally been installed with 32bit node.

I have not yet seen the problem (or anything similar) manifest on any other OS than windows 8, but would not necessarily assume that the bug is specific to 8.... it may be something else in the environment causing the difference in behavior between these machines and (for example) win2k3 machines that are running the same application stack. (Some examples of other known differences between these two environment contexts include differing antivirus and ids/ips firewall, additional file system filter drivers, and slightly modified GPOs - but I have a gut feeling that none of these are likely to be the culprit.)

@joaocgreis joaocgreis added a commit to janeasystems/node-v0.x-archive that referenced this issue Jul 7, 2015
@joaocgreis joaocgreis win,msi: correct installation path registry keys
Since install is per machine only, installation path should be stored
in local machine instead of current user. The registry stores HKLM in
different places for 32 and 64 bit applications, so the installer will
not suggest the old path when upgrading from 32 to 64 bit version.

Fixes #5592
Fixes #25087
65d5d07
@joaocgreis joaocgreis added a commit that referenced this issue Jul 22, 2015
@joaocgreis @orangemocha joaocgreis + orangemocha win,msi: correct installation path registry keys
Since install is per machine only, installation path should be stored
in local machine instead of current user. The registry stores HKLM in
different places for 32 and 64 bit applications, so the installer will
not suggest the old path when upgrading from 32 to 64 bit version.

Fixes #5592
Fixes #25087

PR-URL: #25640
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
Reviewed-By: Bert Belder <bertbelder@gmail.com>
14db629
Member

Fixed by 14db629, but this will only work on fresh installs starting from the next release. Thank you!

@joaocgreis joaocgreis closed this Jul 22, 2015
@joaocgreis joaocgreis added a commit to janeasystems/node that referenced this issue Aug 28, 2015
@joaocgreis joaocgreis win,msi: correct installation path registry keys
This is a port of 14db629.

Original commit message:

  Since install is per machine only, installation path should be stored
  in local machine instead of current user. The registry stores HKLM in
  different places for 32 and 64 bit applications, so the installer
  will not suggest the old path when upgrading from 32 to 64 bit
  version.

  Fixes nodejs/node-v0.x-archive#5592
  Fixes nodejs/node-v0.x-archive#25087

  PR-URL: nodejs/node-v0.x-archive#25640
  Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
  Reviewed-By: Bert Belder <bertbelder@gmail.com>

PR-URL: nodejs#2565
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
c6a54d0
@rvagg rvagg added a commit to rvagg/io.js that referenced this issue Aug 29, 2015
@joaocgreis @rvagg joaocgreis + rvagg win,msi: correct installation path registry keys
This is a port of 14db629.

Original commit message:

  Since install is per machine only, installation path should be stored
  in local machine instead of current user. The registry stores HKLM in
  different places for 32 and 64 bit applications, so the installer
  will not suggest the old path when upgrading from 32 to 64 bit
  version.

  Fixes nodejs/node-v0.x-archive#5592
  Fixes nodejs/node-v0.x-archive#25087

  PR-URL: nodejs/node-v0.x-archive#25640
  Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
  Reviewed-By: Bert Belder <bertbelder@gmail.com>

PR-URL: nodejs#2565
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
4f07cab
@joaocgreis joaocgreis added a commit to nodejs/node that referenced this issue Aug 30, 2015
@joaocgreis @rvagg joaocgreis + rvagg win,msi: correct installation path registry keys
This is a port of 14db629.

Original commit message:

  Since install is per machine only, installation path should be stored
  in local machine instead of current user. The registry stores HKLM in
  different places for 32 and 64 bit applications, so the installer
  will not suggest the old path when upgrading from 32 to 64 bit
  version.

  Fixes nodejs/node-v0.x-archive#5592
  Fixes nodejs/node-v0.x-archive#25087

  PR-URL: nodejs/node-v0.x-archive#25640
  Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
  Reviewed-By: Bert Belder <bertbelder@gmail.com>

PR-URL: #2565
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>

Cherry picked to v3.x by @rvagg, PR:
  #2608
bb24c4a
@jBarz jBarz added a commit to ibmruntimes/node that referenced this issue Nov 4, 2016
@joaocgreis @jBarz joaocgreis + jBarz win,msi: correct installation path registry keys
Since install is per machine only, installation path should be stored
in local machine instead of current user. The registry stores HKLM in
different places for 32 and 64 bit applications, so the installer will
not suggest the old path when upgrading from 32 to 64 bit version.

Fixes #5592
Fixes #25087

PR-URL: nodejs#25640
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
Reviewed-By: Bert Belder <bertbelder@gmail.com>
a5a8fc6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment