Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

RFC: upgrade V8 to 3.24.x #7062

Closed
bnoordhuis opened this issue Feb 6, 2014 · 12 comments
Closed

RFC: upgrade V8 to 3.24.x #7062

bnoordhuis opened this issue Feb 6, 2014 · 12 comments

Comments

@bnoordhuis
Copy link
Member

V8 is currently at 3.24.33, node.js master is still at 3.22.24.19.

The 3.22 branch is unlikely to be maintained for very long so I would suggest upgrading to 3.24.

I have a vested interest in some of the 3.24 functionality, I'm willing to do the work.

@indutny
Copy link
Member

indutny commented Feb 6, 2014

What functionality are you talking about?

I'm okay with upgrading it, considering that we are using 3.22 for quite a long time in 0.11 and it is just out-dated.

@ghost
Copy link

ghost commented Feb 6, 2014

that sounds great.

and if v8 is upgraded to 3.24, then pull request #7021 is not necessary for the issue ( indeed #7020 ) has been fixed in 3.24.

@ghost
Copy link

ghost commented Feb 6, 2014

@trevnorris I guess you are caring about the floating patch? thought I'v no idea what it is.

@bnoordhuis
Copy link
Member Author

What functionality are you talking about?

Primarily interrupt support and allocation site tracking. Allocation site tracking in 3.22 is pretty broken.

@tjfontaine
Copy link

I'm wary to go to 3.24 with out much time to get it burned in, is 3.23 not sufficient?

@bnoordhuis
Copy link
Member Author

I guess so. I know there are one or two minor API bugs in 3.23 but they probably don't affect node. The thing is that there are a number of API changes between 3.22 and 3.23 that will have to be redone on the next major upgrade because 3.24 changes it even more.

Also, and I don't mean any snark, but is time to release really an issue? Going by the pace of development and the number of release blockers in the bug tracker, I get the impression that v0.12 is still a few weeks out.

@tjfontaine
Copy link

Your impression of Node's development cycle aside, 3.24 is still the development branch for v8. Regardless of what will be golden for v8 when 0.12 is released, I am not going to branch 0.12 off with a version of v8 that's still being iterated over.

@bnoordhuis
Copy link
Member Author

I didn't offend you, did I? Sorry, that wasn't my intention, just extrapolating based on what I see. If I'm wrong, tell me.

I am not going to branch 0.12 off with a version of v8 that's still being iterated over.

When will that be? 3.24 is nearing the end of its active development cycle, making it in my opinion the best candidate because it's going to be supported for some time.

Contrast that with v0.10, the version of V8 it shipped was already unsupported on the day v0.10.0 was released. If master stays at 3.22, the same thing is going to happen again.

@trevnorris
Copy link

Personally I like 3.24 just because I can float in the IRHydra 2.0-alpha
patch. :-)

@bnoordhuis
Copy link
Member Author

I want to restart this discussion now that 3.25.0 is out. 3.22 is effectively dead, node.js v0.12 hasn't been released yet. I move that now is a good time to upgrade to 3.24.

(Apologies if this got double-posted, GitHub is acting quirky.)

@indutny
Copy link
Member

indutny commented Feb 21, 2014

@bnoordhuis I'm ok with doing it, just let me remove node_isolate before it. @tjfontaine any objections?

@tjfontaine
Copy link

@bnoordhuis I will review a PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants