Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Update README.md #25875

Closed
wants to merge 1 commit into from
Closed

Update README.md #25875

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 18, 2015

No description provided.

@@ -8,8 +8,8 @@ Prerequisites (Unix only):
* GCC 4.2 or newer
* G++ 4.2 or newer
* Python 2.6 or 2.7
* GNU Make 3.81 or newer
* libexecinfo (FreeBSD and OpenBSD only)
* Windows and Linux and MacOS
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a little silly to add this under "Prerequisites (Unix only)". And why remove make?

@ghost
Copy link
Author

ghost commented Aug 18, 2015

libexecinfo is a library
that's on FreeBSD and not yet but soon OpenBSD
because this is the task
why only GNU Make linux?
There are Windows and MacOS and other linuxes aren't they?

@jasnell
Copy link
Member

jasnell commented Aug 21, 2015

Thanks for the PR. I have not yet reviewed it so I cannot comment on the details, but given that we're in the middle of transitioning to http://github.com/nodejs/node, we won't be landing PRs against master here. If you'd like, please open a new PR either against the v0.12 branch or against master on nodejs/node

@jasnell jasnell added the doc label Aug 27, 2015
@jasnell
Copy link
Member

jasnell commented Aug 27, 2015

As mentioned, this won't land on master in this repo. Please open a new PR against master on nodejs/node if the issue is still relevant there.

@jasnell jasnell closed this Aug 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants