Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

getDiffieHellman: returns a well known, predefined RFC groups #2638

Closed
wants to merge 2 commits into from

Conversation

thinred
Copy link

@thinred thinred commented Jan 29, 2012

Okay, here come the tests and my approach to issue #2338. The only issue here is that they take ~ 4 seconds to complete (because the groups are huge).
I may provide the Python script used to create the header file and hashes for the tests, if you need it.

@bnoordhuis
Copy link
Member

Thanks, Tomasz. Sorry for the delay, got kind of backlogged. I'll merge it but can you sign the CLA first? Are you up for writing the documentation for this?

@thinred
Copy link
Author

thinred commented Feb 21, 2012

I've signed CLA and yes, I can write docs. However, this won't happen before this evening... :)

Tomek

@thinred
Copy link
Author

thinred commented Feb 21, 2012

Well, I couldn't wait. Done.

@bnoordhuis
Copy link
Member

Thanks Tomasz, merged in c6a04ce.

@bnoordhuis bnoordhuis closed this Feb 21, 2012
@thinred
Copy link
Author

thinred commented Feb 24, 2012

Just to make it complete, here is the code I've used to generate headers: https://gist.github.com/1899353 . Thanks!

@VanCoding
Copy link

Thanks very much thinred!
You are my lifesafer!

A question of me at SO:
http://stackoverflow.com/questions/9428342/node-js-diffie-hellman-group1-sha1-error/9429027#9429027

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants