This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
child_process: Add 'close' event for child processes #2944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, a child process does not emit the 'exit' event until 'close' events have been received on all three of the child's stdio streams. This change makes the child object emit 'exit' when the child exits, and a new 'close' event when all stdio streams are closed.
|
LGTM. Other committers? |
|
Squashed and landed on c7b8073. |
This was referenced Mar 29, 2012
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the exit semantics of child processes so that two events are now emitted -
exitandclose- instead of justexit.exit: Theexitevent is now fired when the spawned child process exits, regardless of the state of its stdio streams. The existing behavior was to wait forcloseevents from all stdio streams before emittingexit, which would create various complex situations with inherited stdio handles. (see win:exitevent not emitted as long as a grandchild still exists #2914)close: A newcloseevent is now fired in place of the oldexitevent, i.e. whencloseevents have been received from all stdio streams.