buffer: make SlowBuffer inherit from Buffer #3228
Conversation
This frees us from manually having to copy over functions to SlowBuffer's prototype (which has bitten us multiple times in the past). As an added bonus, the `inspect()` function is now shared between Buffer and SlowBuffer, removing some duplicate code.
|
I'm ok with this, but would like to hear from @bnoordhuis or @piscisaureus before landing. |
|
I am okay with it. The only thing is that I always considered SlowBuffer an implementation detail - when do people use that directly? |
|
@piscisaureus C++ modules returning But exactly because |
|
I'm okay with it. @TooTallNate: How sure are you (percentage-wise) that this won't break anything? |
@bnoordhuis At least 95% :p. I mean I really can't think of any case where it would break anything. No tests break. Any user-land modules still extending |
Check the nodejs-dev mailing list. :-) |
I wanted people to comment on this one because it's somewhat controversial. To anyone who doesn't like the
__proto__usage, the justification is that we do the same thing to theprocessobject to make it be an EventEmtter.But basically this frees us from manually having to copy over functions to SlowBuffer's prototype (which has bitten us multiple times in the past). It's also nice for modules like
buffertoolsor my newrefwhich extend Buffer's prototype, and therefore wouldn't have to do so for SlowBuffer as well.As an added bonus, the
inspect()function is now shared between Buffer and SlowBuffer, removing some duplicate code. There's probably more functions that we could share, but I figured there's probably speed optimizations that should be left in place.Thoughts?
/cc @isaacs @bnoordhuis @piscisaureus