This repository has been archived by the owner. It is now read-only.

Docs fix #4531

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

FLYBYME commented Jan 7, 2013

Fix syntax errors for a few code examples.

Member

bnoordhuis commented Jan 8, 2013

I'll land it but please see https://github.com/joyent/node/blob/master/CONTRIBUTING.md - particularly the sections about the commit log and the CLA.

FLYBYME commented Jan 9, 2013

Sorry about that. I will follow procedure from now on.

isaacs commented Jan 18, 2013

@FLYBYME What @bnoordhuis is saying is: Please sign the cla and reword the commit message, and we'll happily take this.

FLYBYME commented Jan 19, 2013

How would I reword the commit message? Do I recommit it?

I have sign the cla.

git commit --amend

On Fri, Jan 18, 2013 at 10:43 PM, Tim notifications@github.com wrote:

How would I reword the commit message? Do I recommit it?

I have sign the cla.


Reply to this email directly or view it on GitHubhttps://github.com/joyent/node/pull/4531#issuecomment-12451361.

isaacs commented Jan 22, 2013

@FLYBYME Not to worry. Landed with amended commit message in d5a5901.

@isaacs isaacs closed this Jan 22, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.