This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
child_process: handle ENOENT correctly on Windows #4780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -882,9 +882,9 @@ ChildProcess.prototype.spawn = function(options) { | |||
| if (stdio.handle) { | |||
| // when i === 0 - we're dealing with stdin | |||
| // (which is the only one writable pipe) | |||
| stdio.socket = createSocket(stdio.handle, i > 0); | |||
| stdio.socket = createSocket(self.pid !== 0 ? stdio.handle : null, i > 0); | |||
There was a problem hiding this comment.
It's possible I should make this more surgical and also check for process.platform === 'win32'.
|
Ah, sorry for the delay, I thought we were waiting on libuv. Landed on 323120b. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4674
Depends on libuv pull request joyent/libuv#713
We were doing all kinds of crazy stuff on Windows when a developer tried to
child_process.spawn()a non-existent process.Now Windows works more like Posix. And passes the child-process unit tests that were previously failing. And we still pass the unit tests on Posix as well.